Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Generalize internal helper getModelStates #548

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

CharlieFRuan
Copy link
Contributor

This PR reorganizes internal code a bit to reuse code. We rename internal helper method getLLMStates() to getModelStates() and add getEmebeddingStates(), so engine's methods embedding(), completion(), and chatCompletion() can share the same preprocessing helper method.

@CharlieFRuan CharlieFRuan merged commit c7a7285 into mlc-ai:main Aug 14, 2024
1 check passed
@CharlieFRuan CharlieFRuan changed the title [Trivial] Generalize getModelStates [Trivial] Generalize internal helper getModelStates Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant